Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36943 )
Change subject: Use binaries from Windows installer directly ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/c/em100/+/36943/11/em100.h File em100.h:
https://review.coreboot.org/c/em100/+/36943/11/em100.h@191 PS11, Line 191: /* Network */ : void download(char *name, char *id); : int update_all_files(void); : move to network patchset
https://review.coreboot.org/c/em100/+/36943/11/em100.h@199 PS11, Line 199: //char *get_em100_home(void); drop
https://review.coreboot.org/c/em100/+/36943/11/em100.c File em100.c:
https://review.coreboot.org/c/em100/+/36943/11/em100.c@665 PS11, Line 665: drop
https://review.coreboot.org/c/em100/+/36943/11/em100.c@693 PS11, Line 693: // Previously we would just return the first chip if desiredchip was : // not set. TODO figure out the right behavior. : Hence the if(desiredchip ...) further down