Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34790 )
Change subject: vboot: fix conditional using vboot_setup_tpm return value
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34790/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34790/2//COMMIT_MSG@10
PS2, Line 10: In this case, call antirollback_read_space_firmware.
It would be good to mention that the regression was introduced here: CB:34510
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdea1d85167a50a1ada5afe9b107408e3a2e0d6f
Gerrit-Change-Number: 34790
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Pronin
apronin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Thu, 08 Aug 2019 06:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment