Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44196 )
Change subject: mrc_cache: Update mrc_cache data in romstage ......................................................................
Patch Set 24:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44196/24/src/drivers/spi/Kconfig File src/drivers/spi/Kconfig:
https://review.coreboot.org/c/coreboot/+/44196/24/src/drivers/spi/Kconfig@45 PS24, Line 45: BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES
Do you just want a CL with the config and the platforms selecting it in a CL prior to the romstage w […]
Yeah, basically a CL that adds the config BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES which is selected by platforms that need it so that BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY does not get selected for those platforms. You can drop the direct selection of BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY for other platforms in the same CL since the config selection would be redundant. This forms one logical unit.
And finally a CL for MRC changes. This is another logical unit.
It is not weird since the config being added must ensure that there are no functional changes. It is being done to make it easier going forward for platforms to have BOOT_DEVICE_SPI_FLASH_RW_NOMMAP enabled in early stages. So, it should be kept in a change of its own.