build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31616 )
Change subject: superio/ite/common: add option for enabling 5 FANs ......................................................................
Patch Set 4:
(9 comments)
https://review.coreboot.org/#/c/31616/4/src/superio/ite/common/env_ctrl.h File src/superio/ite/common/env_ctrl.h:
https://review.coreboot.org/#/c/31616/4/src/superio/ite/common/env_ctrl.h@60 PS4, Line 60: #define ITE_EC_FAN_TAC_LIMIT(x) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/31616/4/src/superio/ite/common/env_ctrl.h@64 PS4, Line 64: #define ITE_EC_FAN_TAC_EXT_LIMIT(x) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/31616/4/src/superio/ite/common/env_ctrl.h@87 PS4, Line 87: #define ITE_EC_FAN_CTL_PWM_CONTROL(x) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/31616/4/src/superio/ite/common/env_ctrl.h@14... PS4, Line 144: #define ITE_EC_FAN_CTL_TEMP_LIMIT_OFF(x) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/31616/4/src/superio/ite/common/env_ctrl.h@14... PS4, Line 148: #define ITE_EC_FAN_CTL_TEMP_LIMIT_START(x) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/31616/4/src/superio/ite/common/env_ctrl.h@15... PS4, Line 152: #define ITE_EC_FAN_CTL_TEMP_LIMIT_FULL(x) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/31616/4/src/superio/ite/common/env_ctrl.h@15... PS4, Line 156: #define ITE_EC_FAN_CTL_PWM_START(x) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/31616/4/src/superio/ite/common/env_ctrl.h@16... PS4, Line 160: #define ITE_EC_FAN_CTL_PWM_AUTO(x) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/31616/4/src/superio/ite/common/env_ctrl.h@16... PS4, Line 164: #define ITE_EC_FAN_CTL_DELTA_TEMP(x) \ Macros with complex values should be enclosed in parentheses