Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40291 )
Change subject: vc/amd/agesa/f.../Proc/Mem/Tech/DDR3: Support XMP memory profiles ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/40291/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40291/1//COMMIT_MSG@7 PS1, Line 7: vendorcode
vc
Done
https://review.coreboot.org/c/coreboot/+/40291/1//COMMIT_MSG@7 PS1, Line 7: vendorcode/amd/agesa/.../Mem/Tech/DDR3: XMP memory profiles support
Please make that a statement by adding a verb (in imperative mood): […]
Done
https://review.coreboot.org/c/coreboot/+/40291/1//COMMIT_MSG@10 PS1, Line 10: Added using the datasheets from https://github.com/mikebdp2/ddr3spd
Please list the name and section for one family.
Done?
https://review.coreboot.org/c/coreboot/+/40291/1/src/vendorcode/amd/agesa/Kc... File src/vendorcode/amd/agesa/Kconfig:
https://review.coreboot.org/c/coreboot/+/40291/1/src/vendorcode/amd/agesa/Kc... PS1, Line 22:
Please remove the white space.
Done
https://review.coreboot.org/c/coreboot/+/40291/1/src/vendorcode/amd/agesa/Kc... PS1, Line 25: a coreboot's fork
Just *coreboot’s fork*?
Done ;)
https://review.coreboot.org/c/coreboot/+/40291/1/src/vendorcode/amd/agesa/Kc... PS1, Line 35: at
on?
Done
https://review.coreboot.org/c/coreboot/+/40291/1/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f14/Proc/Mem/Tech/DDR3/mtspd3.h:
https://review.coreboot.org/c/coreboot/+/40291/1/src/vendorcode/amd/agesa/f1... PS1, Line 167: bit
bits?
Done