Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40705 )
Change subject: drivers/ipmi: Add uid parameter to struct drivers_ipmi_config ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40705/7/src/drivers/ipmi/ipmi_kcs_o... File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/40705/7/src/drivers/ipmi/ipmi_kcs_o... PS7, Line 215: conf->uid); What will happen if (conf == NULL) ? My conpiler complains "potential null pointer dereference [-Werror=null-dereference]" here.
https://review.coreboot.org/c/coreboot/+/40705/7/src/drivers/ipmi/ipmi_kcs_o... PS7, Line 239: conf->uid = uid_cnt++; What will happen if (conf == NULL) ?