Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46119 )
Change subject: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46119/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46119/3//COMMIT_MSG@8
PS3, Line 8:
This looks modelled strangely. If it’s configuration, why doesn’t it go into Kconfig or devicetree?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46119
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe7c6ad03a83a6a3b2c7dfcfafaa619e690a418d
Gerrit-Change-Number: 46119
Gerrit-PatchSet: 3
Gerrit-Owner: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Oct 2020 13:01:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment