Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34159 )
Change subject: mb/intel/coffeelake_rvp: Fix display issues on CFL-H, CFL-S, WHL Intel RVP ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34159/4/src/mainboard/intel/coffeel... File src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/34159/4/src/mainboard/intel/coffeel... PS4, Line 596: #if CONFIG(SOC_INTEL_CANNONLAKE_PCH_H) remove tab
https://review.coreboot.org/c/coreboot/+/34159/4/src/mainboard/intel/coffeel... File src/mainboard/intel/coffeelake_rvp/variants/whl_u/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34159/4/src/mainboard/intel/coffeel... PS4, Line 18: register "DdiPortFHpd" = "0" if display is coming using coreboot + depthcharge on WHL-U which i know without this CL, then why we are changing this code ?
then it would be something specific on panel ?