[coreboot-gerrit] Change in coreboot[master]: soc/amd/common/espi: Clear DNCMD_COMPLETE on completion

[Furquan Shaikh (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52056 )

Change subject: soc/amd/common/espi: Clear DNCMD_COMPLETE on completion
......................................................................

Patch Set 2:

(1 comment)

File src/soc/amd/common/block/lpc/espi_util.c:

https://review.coreboot.org/c/coreboot/+/52056/comment/e4a07f0f_8d8aa053 
PS2, Line 475: return -1;
> I wanted to leave all the evidence in case of a failure. […]

I think it is okay to leave the bit as is in case of failure. I wanted to make sure this was intentional.

Also, I am curious, is the bit being cleared in successful case because we are seeing unexpected behavior later because of bit remaining set? I see there is already a call to `espi_clear_status()` at the start of this function to ensure we start clean state before a new transaction. So, the motivation behind this change wasn't very clear to me.