Attention is currently required from: Michael Niewöhner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52810 )
Change subject: soc/intel/skylake: Use set_dev_state_by_devicetree()
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/skylake/chip.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118316):
https://review.coreboot.org/c/coreboot/+/52810/comment/27eafca5_6dc7e5f4
PS8, Line 461: if (!xdci_can_enable()) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75088098a4cceea2e860ca97c4853d2e5279c2f2
Gerrit-Change-Number: 52810
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 04 May 2021 03:12:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment