Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36992 )
Change subject: mb/gigabyte/ga-b75m-d3h: Add ga-b75-d3v as a variant ......................................................................
Patch Set 9: Code-Review+1
(3 comments)
Looks good.
https://review.coreboot.org/c/coreboot/+/36992/9/src/mainboard/gigabyte/ga-b... File src/mainboard/gigabyte/ga-b75m-d3h/Kconfig:
https://review.coreboot.org/c/coreboot/+/36992/9/src/mainboard/gigabyte/ga-b... PS9, Line 47: default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb" you can make this conditional if you are not overriding things on some boards.
https://review.coreboot.org/c/coreboot/+/36992/9/src/mainboard/gigabyte/ga-b... File src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/36992/9/src/mainboard/gigabyte/ga-b... PS9, Line 26: /* NID 0x11. */ IMO these are redundant.
https://review.coreboot.org/c/coreboot/+/36992/9/src/mainboard/gigabyte/ga-b... File src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36992/9/src/mainboard/gigabyte/ga-b... PS9, Line 20: io 0x62 = 0x230 is it really necessary to override this? There is nothing else set up to decode this.