Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )
Change subject: hatch: automate creating a new variant in coreboot ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/scripts/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 136: git add KConfig KConfig.name : : # Now commit the files : git commit -m "${base,,}: Create ${variant,,} variant : : BUG=none : TEST=util/abuild/abuild -p none -t google/${base,,} -x -a : make sure the build includes GOOGLE_{variant^^} : : Signed-off-by: ${name} <${email}>"
I don't think we need to add the git logic to the script. […]
Eventually, this script and others will be called in a sequence, everything will be git committ'ed and repo upload'ed, and you just have to get the CLs reviewed and CQ+2'ed. So I think we need to keep the git logic.