12 Oct
2019
12 Oct
'19
7:07 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30810 )
Change subject: device/pci_device.c: Use verified boot to check oprom ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/30810/10/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/30810/10/src/device/pci_device.c@75... PS10, Line 750: if (!should_run_oprom(dev, rom)) Why is `rom` checked and not the `ram` copy? And if there is a reason to accept the TOCTOU weakness, why load it if it doesn't verify?
--
To view, visit https://review.coreboot.org/c/coreboot/+/30810
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec5092e85d34940ea3a3bb1192ea49f3bc3e5b27
Gerrit-Change-Number: 30810
Gerrit-PatchSet: 10
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 12 Oct 2019 17:07:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment