Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46249 )
Change subject: mb/clevo/l140cu: Correct FSP-M UPDs ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/romstage.c:
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v... PS1, Line 7: /* Parameters required to access SPD for CH0D0/CH0D1/CH1D0/CH1D1. */ Please drop this comment
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v... PS1, Line 10: .spd_spec = {.spd_index = 0},
already done in CB:46248 ;)
reading my previous comment again, don't remove the index = 0. it's intentionally zero.