build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23742 )
Change subject: soc/intel/{glk,apl} and mainboards: Configure LPC_CLKRUN# pin as GPIO for S0ix ......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/#/c/23742/10/src/mainboard/google/octopus/varian... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/23742/10/src/mainboard/google/octopus/varian... PS10, Line 213: * GPIO_154 - LPC_CLKRUN# has a native function for LPC but not for eSPI. line over 80 characters
https://review.coreboot.org/#/c/23742/10/src/mainboard/google/octopus/varian... PS10, Line 214: * Nonetheless if we use eSPI, it should be configured as a GPIO and kept line over 80 characters
https://review.coreboot.org/#/c/23742/10/src/mainboard/google/octopus/varian... File src/mainboard/google/octopus/variants/bip/gpio.c:
https://review.coreboot.org/#/c/23742/10/src/mainboard/google/octopus/varian... PS10, Line 212: * GPIO_154 - LPC_CLKRUN# has a native function for LPC but not for eSPI. line over 80 characters
https://review.coreboot.org/#/c/23742/10/src/mainboard/google/octopus/varian... PS10, Line 213: * Nonetheless if we use eSPI, it should be configured as a GPIO and kept line over 80 characters