Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40538 )
Change subject: tests: Add lib/string-test test case
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40538/2/tests/lib/string-test.c
File tests/lib/string-test.c:
https://review.coreboot.org/c/coreboot/+/40538/2/tests/lib/string-test.c@34
PS2, Line 34: assert_int_equal(0, memcmp(str, duplicate, strlen(str)));
Yes, but the trick is that assert_string_equal() is using.. […]
In that case, add a comment in this function that you're using assert_int_equal and memcmp instead of assert_string_equal because you don't want to use strcmp.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40538
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf5554d1e99a393721a66bdd35af0122c2e412c4
Gerrit-Change-Number: 40538
Gerrit-PatchSet: 3
Gerrit-Owner: Name of user not set #1002873
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Apr 2020 15:26:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Name of user not set #1002873
Gerrit-MessageType: comment