Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46489 )
Change subject: configs: Add TXT-enabled config for Asrock B85M Pro4
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46489/1/configs/config.asrock_b85m_...
File configs/config.asrock_b85m_pro4.tpm2_txt_placeholder_acms:
https://review.coreboot.org/c/coreboot/+/46489/1/configs/config.asrock_b85m_...
PS1, Line 8: CONFIG_INTEL_TXT_BIOSACM_FILE="3rdparty/blobs/cpu/intel/stm/stm.bin"
Can we add a fake ACM? Something that has the correct header but no payload?
I'd rather add a proper ACM, but I don't think it's easy because of licenses.
Can we take care of that later on, please? I'd like to get this change in to get the Haswell TXT code build-tested.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46489
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf8db5fdfac5b527520023277c6370f6efa71717
Gerrit-Change-Number: 46489
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 20 Oct 2020 11:27:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment