Attention is currently required from: Ashish Kumar Mishra, Karthik Ramasubramanian, Paul Menzel.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81437?usp=email )
Change subject: lib/spd_bin: Add LPDDR5X dram_type in use_ddr4_params ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81437/comment/9d237f43_897567a8 : PS2, Line 9: For dram_type 21 the switch case in use_ddr4_params : function falls to default. This adds SPD_DRAM_LPDDR5X dram_type : case to switch case block for dram_type 21 in the function.
Please use 72 characters per line (besides pasted lines).
Please state the user visible problem:
On google/brox, coreboot currently logs the line below.
[NOTE ] Defaulting to using DDR4 params. Please add dram_type check for 21 to use_ddr4_params
Follow the instruction, and add the macro SPD_DRAM_LPDDR5X in `use_ddr4_params()`.
exactly. this is how you should write the commit msg to highlight a user visible problem and what fix u r providing.