Jakub Czapiga has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75354 )
Change subject: mb/google/corsola: Disable backlight before turning on bridge ......................................................................
mb/google/corsola: Disable backlight before turning on bridge
Disable backlight before turning on bridge, otherwise the bridge will initialize failed.
Fixes: d5c1e1(mb/google/corsola: Add support for MIPI panel) Signed-off-by: Ruihai Zhou zhouruihai@huaqin.corp-partner.google.com Change-Id: I7d10bf9e8675b2fb03bfd1e294af66207b9b0620 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75354 Reviewed-by: cong yang yangcong5@huaqin.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Yidi Lin yidilin@google.com --- M src/mainboard/google/corsola/display.c 1 file changed, 21 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Yidi Lin: Looks good to me, approved cong yang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/corsola/display.c b/src/mainboard/google/corsola/display.c index 697db07..9a8ecc5 100644 --- a/src/mainboard/google/corsola/display.c +++ b/src/mainboard/google/corsola/display.c @@ -123,6 +123,9 @@
int configure_display(void) { + /* Set up backlight control pins as output pin and power-off by default */ + backlight_control(); + const struct panel_description *panel = get_active_panel();
if (!panel) @@ -130,9 +133,6 @@
printk(BIOS_INFO, "%s: Starting display init\n", __func__);
- /* Set up backlight control pins as output pin and power-off by default */ - backlight_control(); - if (panel->power_on) panel->power_on();