Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )
Change subject: hatch: automate creating a new variant in coreboot ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/scripts/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 34: echo <<EOF >variants/${variant,,}/include/variant/acpi/dptf.asl
Since you are seeding this, you are setting the standard that people will use/copy. […]
I'm changing it over to use template files (*.tmpl, in the same directory as the script), and sed to put the correct year into the text. The template files and the overridetree.cb (which does not need to be a template) do not contain the name of the baseboard or the variant.
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 38: 2019
We will want this date to update
As noted above, the year in each template file will be substituted with the current year at the time the script runs.
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 119: #
should these be source code comments instead?
I think these are appropriate in the makefile. The C source code doesn't actually refer to any of the SPD names, just indices into the SPD array.
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 143: make sure the build includes GOOGLE_{variant^^}
if we are keeping the git stuff, then we can use the -s option on git so we don't have to manually w […]
Done
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 136: git add KConfig KConfig.name : : # Now commit the files : git commit -m "${base,,}: Create ${variant,,} variant : : BUG=none : TEST=util/abuild/abuild -p none -t google/${base,,} -x -a : make sure the build includes GOOGLE_{variant^^} : : Signed-off-by: ${name} <${email}>"
Six. […]
Done