Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35166 )
Change subject: soc/skl/vr_config: add missed Icc max levels ......................................................................
Patch Set 6:
(4 comments)
Tested how?
https://review.coreboot.org/c/coreboot/+/35166/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35166/6//COMMIT_MSG@7 PS6, Line 7: soc/skl/vr_config: add missed Icc max levels Maybe:
Increase Icc max level to 48 A
https://review.coreboot.org/c/coreboot/+/35166/6//COMMIT_MSG@26 PS6, Line 26: add adds
https://review.coreboot.org/c/coreboot/+/35166/6//COMMIT_MSG@27 PS6, Line 27: VR domain Dot/period at the end please.
https://review.coreboot.org/c/coreboot/+/35166/6/src/soc/intel/skylake/vr_co... File src/soc/intel/skylake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/35166/6/src/soc/intel/skylake/vr_co... PS6, Line 143: VR_CFG_AMP(48), This should be mentioned in the commit message.