Name of user not set #1003143 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47642 )
Change subject: tests: Add lib/cbmem_console-test test case ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47642/1/tests/lib/cbmem_console-tes... File tests/lib/cbmem_console-test.c:
https://review.coreboot.org/c/coreboot/+/47642/1/tests/lib/cbmem_console-tes... PS1, Line 10: /* Weak references have to be here, so TEST_REGION macro will work properly */ : __weak extern u8 _preram_cbmem_console[]; : __weak extern u8 _epreram_cbmem_console[]; : : #define PRERAM_CBMEM_CONSOLE_SIZE (1 * KiB) : TEST_REGION(preram_cbmem_console, PRERAM_CBMEM_CONSOLE_SIZE);
style nit: these don't need to be indented inside a #if block
Done
https://review.coreboot.org/c/coreboot/+/47642/1/tests/lib/cbmem_console-tes... PS1, Line 85: assert_int_equal(ARRAY_SIZE(data), cursor);
Should you check the contents to verify the correct behavior on overflow (keep oldest data or keep n […]
Done