Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35165 )
Change subject: arch/x86: Reserve some CAR memory for FSP single stack requirement ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35165/4/src/arch/x86/car.ld File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/35165/4/src/arch/x86/car.ld@96 PS4, Line 96: CONFIG_C_ENVIRONMENT_BOOTBLOCK Are we dependent on this? I don't think we are.
https://review.coreboot.org/c/coreboot/+/35165/4/src/arch/x86/car.ld@102 PS4, Line 102: CONFIG_DCACHE_BSP_HEAP_SIZE Put 'FSP' in the name since it has only to do w/ FSP. Same for the symbols -- add 'fsp' in there.