[coreboot-gerrit] [XL] Change in coreboot[main]: soc/mediatek/common/dp: Move common functions to dptx_hal_common.c

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85861?usp=email )

Change subject: soc/mediatek/common/dp: Move common functions to dptx_hal_common.c
......................................................................

Patch Set 6:

(1 comment)

File src/soc/mediatek/common/dp/dptx_hal_common.c:

https://review.coreboot.org/c/coreboot/+/85861/comment/2fe9fdf6_57704241?usp... :
PS3, Line 115: 	DP_CLRSETBITS(mtk_dp, REG_303C_DP_ENCODER0_P0 + 1, val, 0x7);
> Checked with MTK, `DP_TX_TOP_APB_WSTRB` only takes effect on previous SoCs. […]

Great! That makes a lot of sense.