Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35117 )
Change subject: soc/sifive/fu540: test and fix code of fu540 spi
......................................................................
Patch Set 3: -Code-Review
(2 comments)
https://review.coreboot.org/c/coreboot/+/35117/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35117/3//COMMIT_MSG@10
PS3, Line 10: (
space before, not after
https://review.coreboot.org/c/coreboot/+/35117/3/src/soc/sifive/fu540/spi.c
File src/soc/sifive/fu540/spi.c:
https://review.coreboot.org/c/coreboot/+/35117/3/src/soc/sifive/fu540/spi.c@...
PS3, Line 148: -1
The argument is uint32_t
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35117
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60033a148c21bbd5b4946580f6cab0b439d346c6
Gerrit-Change-Number: 35117
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn C
citypw@hardenedlinux.org
Gerrit-Reviewer: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Oct 2019 10:35:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment