Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69932 )
Change subject: drivers/wwan/fm: Use correct GUID for DmaProperty in ACPI _DSD ......................................................................
drivers/wwan/fm: Use correct GUID for DmaProperty in ACPI _DSD
Use correct GUID for DmaProperty in ACPI _DSD.
Reference: https://learn.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-...
Before: Name (_DSD, Package (0x02) // _DSD: Device-Specific Data { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */, Package (0x01) { Package (0x02) { "DmaProperty", One } } })
After: Name (_DSD, Package (0x02) // _DSD: Device-Specific Data { ToUUID ("70d24161-6dd5-4c9e-8070-705531292865"), Package (0x01) { Package (0x02) { "DmaProperty", One } } })
BUG=b:259716145 TEST=Verified the new GUID is reflected in ACPI SSDT at runtime.
Signed-off-by: Kapil Porwal kapilporwal@google.com Change-Id: I05b8c3bf23cc43863527bc514d9a96096d45003c --- M src/drivers/wwan/fm/acpi_fm350gl.c 1 file changed, 53 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/69932/1
diff --git a/src/drivers/wwan/fm/acpi_fm350gl.c b/src/drivers/wwan/fm/acpi_fm350gl.c index dbc4f24..7ff8b2b 100644 --- a/src/drivers/wwan/fm/acpi_fm350gl.c +++ b/src/drivers/wwan/fm/acpi_fm350gl.c @@ -5,6 +5,9 @@ #include "chip.h" #include "soc/intel/common/block/pcie/rtd3/chip.h"
+/* ID for the DmaProperty in _DSD */ +#define ACPI_DSD_DMA_PROPERTY_UUID "70D24161-6DD5-4C9E-8070-705531292865" + /* FCPO# to RESET# delay time during WWAN ON */ #define FM350GL_TN2B 20 /* RESET# to PERST# delay time during WWAN ON */ @@ -243,9 +246,11 @@ wwan_fm350gl_acpi_method_dpts(parent, config);
if (config->add_acpi_dma_property) { - struct acpi_dp *dsd; + struct acpi_dp *dsd, *pkg; dsd = acpi_dp_new_table("_DSD"); - acpi_dp_add_integer(dsd, "DmaProperty", 1); + pkg = acpi_dp_new_table(ACPI_DSD_DMA_PROPERTY_UUID); + acpi_dp_add_integer(pkg, "DmaProperty", 1); + acpi_dp_add_package(dsd, pkg); acpi_dp_write(dsd); }