Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32617 )
Change subject: mb/lenovo/*: Add support for VBOOT on 12MiB devices
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32617/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/32617/5//COMMIT_MSG@18
PS5, Line 18: Untested.
It's still untested on the T440P. Haven't had time for proper testing yet.
As far as I can see the T440P blocks the progress here, right? IMO we should remove it from this commit and create a seperate commit for it. So we can merge this one at least.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32617
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a35a06ece1e9d57a2ef23970e61ae26fafce543
Gerrit-Change-Number: 32617
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Jonas Moehle
ad-min@mailbox.org
Gerrit-Reviewer: Martin Kepplinger
martink@posteo.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 29 Dec 2019 00:05:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonas Moehle
ad-min@mailbox.org
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment