Attention is currently required from: Paul Menzel, Philipp Hug.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81306?usp=email )
Change subject: arch/riscv: Add basic illegal instruction handling ......................................................................
Patch Set 11:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81306/comment/4f43bae4_145fbfc2 : PS11, Line 7: arch/riscv: Basic illegal instruction handling
Just a nit: It’d be great if you made this a statement by adding a verb in imperative mood. […]
Done
https://review.coreboot.org/c/coreboot/+/81306/comment/d57f3e1f_38e0857d : PS11, Line 23:
Other nit: The blank line can be removed.
Done
File src/arch/riscv/trap_handler.c:
https://review.coreboot.org/c/coreboot/+/81306/comment/fb77d58a_63083eee : PS11, Line 116: testing_linuxcheck
Mention this in the commit message too?
oops, that should not have been here, thanks. It's moved now.
https://review.coreboot.org/c/coreboot/+/81306/comment/1204eefa_a7b5c2e3 : PS11, Line 128: provided
provide
Done