Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33046 )
Change subject: nb/intel/nehalem: Call smm_region_start() function ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/33046/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33046/2//COMMIT_MSG@7 PS2, Line 7: nb/intel/nehalem: Call smm_region_start() function it does more than that now
https://review.coreboot.org/#/c/33046/2/src/northbridge/intel/nehalem/ram_ca... File src/northbridge/intel/nehalem/ram_calc.c:
https://review.coreboot.org/#/c/33046/2/src/northbridge/intel/nehalem/ram_ca... PS2, Line 38: return (u32)smm_region_start(); maybe it should be the other way around, smm_region_start() calling northbridge_get_tseg_base(), then you wouldn't need the cast here. otoh, then you could also manually inline smm_region_start() below and would need a cast there ;)