Balázs Vinarz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30895 )
Change subject: Documentation: Add Asus F2A85-M ......................................................................
Patch Set 6:
(10 comments)
So the new patchset in online, can I have a review?
Regards
https://review.coreboot.org/#/c/30895/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30895/1//COMMIT_MSG@7 PS1, Line 7: 1st version 1:1 copy from old wiki https://www.coreboot.org/Board:asus/f2a85-m
This is not a proper commit summary. […]
Ack
https://review.coreboot.org/#/c/30895/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30895/2//COMMIT_MSG@8 PS2, Line 8: 2nd version, reworked based on Asus P8H61-M LX as a template and the old wiki
Please add an empty line between the commit summary and the rest of the commit message
Ack
https://review.coreboot.org/#/c/30895/2/Documentation/mainboard/asus/f2a85-m... File Documentation/mainboard/asus/f2a85-m.md:
https://review.coreboot.org/#/c/30895/2/Documentation/mainboard/asus/f2a85-m... PS2, Line 8: - ASUS F2A85-M PRO - the most available model in the entire F2A85 series. Be sure to check its status to see what works and what doesn't.
I think there is a line length limit, this mahy have to be split
Ack
https://review.coreboot.org/#/c/30895/2/Documentation/mainboard/asus/f2a85-m... PS2, Line 19: AX
What does this mean?
Ack
https://review.coreboot.org/#/c/30895/4/Documentation/mainboard/asus/f2a85-m... File Documentation/mainboard/asus/f2a85-m.md:
https://review.coreboot.org/#/c/30895/4/Documentation/mainboard/asus/f2a85-m... PS4, Line 15: are
is
Ack
https://review.coreboot.org/#/c/30895/5/Documentation/mainboard/asus/f2a85-m... File Documentation/mainboard/asus/f2a85-m.md:
https://review.coreboot.org/#/c/30895/5/Documentation/mainboard/asus/f2a85-m... PS5, Line 105: b5016 is untested, but expected to work as well
use a block
Done
https://review.coreboot.org/#/c/30895/5/Documentation/mainboard/asus/f2a85-m... PS5, Line 120: Fortunately it is possible to downgrade build v6502, v6501 and v6404 to v6402, with EZFlash.
limit to 80 chars
Done
https://review.coreboot.org/#/c/30895/5/Documentation/mainboard/asus/f2a85-m... PS5, Line 135: - Select the 'export path' and 'link present' and option ROM '1002,9900' and click on 'Extract'
limit to 80 chars
Done
https://review.coreboot.org/#/c/30895/5/Documentation/mainboard/asus/f2a85-m... PS5, Line 137: This version is usable for all the GPUs.
use a block
Done
https://review.coreboot.org/#/c/30895/5/Documentation/mainboard/asus/f2a85-m... PS5, Line 189: - [Flash chip datasheet][W25Q64FV]
does that work ?
yes, the link is alive