So the new patchset in online, can I have a review?

Regards

View Change

10 comments:

• Commit Message:

  • Patch Set #1, Line 7: 1st version 1:1 copy from old wiki https://www.coreboot.org/Board:asus/f2a85-m

    This is not a proper commit summary. […]

    Ack

• Commit Message:

  • Patch Set #2, Line 8: 2nd version, reworked based on Asus P8H61-M LX as a template and the old wiki

    Please add an empty line between the commit summary and the rest of the commit message

    Ack

• File Documentation/mainboard/asus/f2a85-m.md:

  • Patch Set #2, Line 8: - ASUS F2A85-M PRO - the most available model in the entire F2A85 series. Be sure to check its status to see what works and what doesn't.

    I think there is a line length limit, this mahy have to be split

    Ack

  • Patch Set #2, Line 19: AX

    What does this mean?

    Ack

• File Documentation/mainboard/asus/f2a85-m.md:

  • Patch Set #4, Line 15: are

    is

    Ack

• File Documentation/mainboard/asus/f2a85-m.md:

  • Patch Set #5, Line 105: b5016 is untested, but expected to work as well

    use a block

    Done

  • Patch Set #5, Line 120: Fortunately it is possible to downgrade build v6502, v6501 and v6404 to v6402, with EZFlash.

    limit to 80 chars

    Done

  • Patch Set #5, Line 135: - Select the 'export path' and 'link present' and option ROM '1002,9900' and click on 'Extract'

    limit to 80 chars

    Done

  • Patch Set #5, Line 137: This version is usable for all the GPUs.

    use a block

    Done

  • Patch Set #5, Line 189: - [Flash chip datasheet][W25Q64FV]

    does that work ?

    yes, the link is alive

To view, visit change 30895. To unsubscribe, or for help writing mail filters, visit settings.