[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Move GPIO PM configuration to soc level

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37685 )

Change subject: soc/intel/cannonlake: Move GPIO PM configuration to soc level
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37685/5/src/soc/intel/cannonlake/ac... 
File src/soc/intel/cannonlake/acpi/lpit.asl:

https://review.coreboot.org/c/coreboot/+/37685/5/src/soc/intel/cannonlake/ac... 
PS5, Line 79: /* Enable GPIO PM */
            : 				_SB.PCI0.LOCL (MISCCFG_ENABLE_GPIO_PM_CONFIG)
> I prefer we can keep the device tree setting and store it into GNVS. […]

i like the GNVS way of doing things and this is good method to pass value from .c to .asl.

Do you want me to implement that part, please let me know