[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: boot up sspm

[Tristan Hsieh (Code Review)]

Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )

Change subject: google/kukui: boot up sspm
......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/include/soc/... 
File src/soc/mediatek/mt8183/include/soc/addressmap.h:

https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/include/soc/... 
PS1, Line 37:                
tab

https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/include/soc/... 
File src/soc/mediatek/mt8183/include/soc/sspm.h:

https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/include/soc/... 
PS1, Line 26: #define CFG_SSPM_SRAM	0x10400000
> move this line in between line 20~22

How about we move it to addresmap.h?

https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/include/soc/... 
PS1, Line 27: s32
Would it be better to return int?