25 Nov
2022
25 Nov
'22
12:03 p.m.
Attention is currently required from: Mario Scheithauer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69972 )
Change subject: mb/siemens/mc_ehl2: Disable GSPI2 controller ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/69972/comment/081d490b_6c270ff1 PS2, Line 145: device pci 12.0 on end # GSPI2 Why is setting it to `off` not enough, so it’s clear it could theoretically be enabled?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69972
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e7462312953d50385ca7bb2f2e0abb8fc3a5886
Gerrit-Change-Number: 69972
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Comment-Date: Fri, 25 Nov 2022 10:03:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment