[coreboot-gerrit] Change in coreboot[master]: soc/intel/braswell/smbus.c: Define __SIMPLE_DEVICE__

[Michael Niewöhner (Code Review)]

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52456 )

Change subject: soc/intel/braswell/smbus.c: Define __SIMPLE_DEVICE__
......................................................................

soc/intel/braswell/smbus.c: Define __SIMPLE_DEVICE__

Change-Id: Ic16fd74d4ddf96e29bcdada671dab0e590af74ef
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52456
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Michael Niewöhner 
Reviewed-by: Frans Hendriks 
---
M src/soc/intel/braswell/smbus.c
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Frans Hendriks: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved
  Michael Niewöhner: Looks good to me, approved

diff --git a/src/soc/intel/braswell/smbus.c b/src/soc/intel/braswell/smbus.c
index 11a3063..733c159 100644
--- a/src/soc/intel/braswell/smbus.c
+++ b/src/soc/intel/braswell/smbus.c
@@ -1,5 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

+#define __SIMPLE_DEVICE__
+
 #include <soc/iomap.h>
 #include <soc/pci_devs.h>
 #include <device/pci_def.h>
@@ -10,11 +12,8 @@

int smbus_i2c_block_write(u8 addr, u8 bytes, u8 *buf)
 {
-#ifdef __SIMPLE_DEVICE__
-	pci_devfn_t dev = PCI_DEV(0, SMBUS_DEV, SMBUS_FUNC);
-#else
-	struct device *dev = pcidev_on_root(SMBUS_DEV, SMBUS_FUNC);
-#endif
+	const pci_devfn_t dev = PCI_DEV(0, SMBUS_DEV, SMBUS_FUNC);
+
    u32 smbase;
    u32 smb_ctrl_reg;
    int status;