Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34561 )
Change subject: Documentation/soc/amd: Add Family 15h ......................................................................
Patch Set 8:
(14 comments)
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... File Documentation/soc/amd/family15h.md:
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 5: Family 15h (Bulldozer) is a microprocessor microarchitecture first released in : 2011.
What about something like […]
Done
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 8: threads
cores
Done
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 9: thread
core
Done
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 13: replaces
replace
Removed
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 13: Family 15h [SOC|Processors] products are x86-based designs that replaces previous : SMT schema with CMT
Huh? AMD never had SMT in a previous product.
Misunderstood from reading Wikipedia document on Bulldozer. Removed.
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 14: ..
2 periods
Removed.
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 22: .
All families weren't identical. […]
Later models (they are all Family 15h)...Yes, added the info.
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 24: A die also includes
Some products include
Done
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 26: (grounding a pin
I would remove this
Done
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 27: validated
how about authenticated
Done
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 31: _AGESA ™_). _AGESA_
Why are you italicizing?
Done
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 37: _Merlin Falcon_) and 70h-7Fh (_Stoney Ridge_)
Why are you italicizing?
Done
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 40: ## Additional Definitions
I'm not sure you need additional definitions anymore. […]
Done
https://review.coreboot.org/c/coreboot/+/34561/8/Documentation/soc/amd/famil... PS8, Line 45:
extra whitespace?
So that the unformatted document with a regular text editor looks identical to a formatted one through markdown reader. As far as I tested, markdown readers are smart enough to ignore the extra space, so I did it on purpose.