Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/16328 )
Change subject: util/intelmetool: Add bootguard information dump support ......................................................................
Patch Set 21:
(5 comments)
@Nicola which bits 20:21 and where do we get them. Normally the bootguard enforcement policies are somewhere in the ME pci config space but we don't know where exactly. If you have information about it please give me some input or make modifications yourself.
https://review.coreboot.org/#/c/16328/9/util/intelmetool/intelmetool.c File util/intelmetool/intelmetool.c:
https://review.coreboot.org/#/c/16328/9/util/intelmetool/intelmetool.c@129 PS9, Line 129:
you have ME hardware on board but...
Done
https://review.coreboot.org/#/c/16328/9/util/intelmetool/msr.c File util/intelmetool/msr.c:
https://review.coreboot.org/#/c/16328/9/util/intelmetool/msr.c@29 PS9, Line 29: static uint64_t rdmsr(int addr)
static int ...
Done
https://review.coreboot.org/#/c/16328/9/util/intelmetool/msr.c@60 PS9, Line 60:
include errno.h instead of hardcoding values
Done
https://review.coreboot.org/#/c/16328/9/util/intelmetool/msr.c@73 PS9, Line 73: #endif
Return error code and pass msr value by argument
Done
https://review.coreboot.org/#/c/16328/9/util/intelmetool/msr.c@85 PS9, Line 85:
O_RDONLY
Done