Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33824 )
Change subject: DO NOT SUBMIT: It's just to study how to create a new variant.
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33824/5/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/33824/5/src/mainboard/google/hatch/...
PS5, Line 73: chip drivers/i2c/hid
: register "generic.hid" = ""PNP0C50""
: register "generic.desc" = ""Synaptics Touchpad""
: register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_A21_IRQ)"
: register "generic.wake" = "GPE0_DW0_21"
: register "generic.probed" = "1"
: register "hid_desc_reg_offset" = "0x20"
: device i2c 0x2c on end
: end
Add Synaptics touchpad configuration.
https://review.coreboot.org/c/coreboot/+/33824/5/src/mainboard/google/hatch/...
PS5, Line 95: device i2c 10 on end
slave address is 0x10 and follow our panel setting.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33824
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a868839e2c598f8052d37c99713bc58b21e887c
Gerrit-Change-Number: 33824
Gerrit-PatchSet: 5
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Ma
magf@bitland.corp-partner.google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Xingyu Wu
wuxy@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jul 2019 09:21:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment