[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: boot up sspm

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )

Change subject: google/kukui: boot up sspm
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/31516/2/src/mainboard/google/kukui/Kconfig 
File src/mainboard/google/kukui/Kconfig:

https://review.coreboot.org/#/c/31516/2/src/mainboard/google/kukui/Kconfig@6... 
PS2, Line 68: config SSPM_BIN_FILE
Why is this a Kconfig? This should just be a well-known name (e.g. 3rdparty/blobs/soc/mediatek/mt8183/sspm.bin). Then commit the binary to https://review.coreboot.org/cgit/blobs.git.

https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... 
File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... 
PS1, Line 44: unsigned char buf[BUF_SIZE];
> That's an interesting idea... yes I think that may also work... […]

Yeah, that's definitely the right thing to do, don't copy 64KB around more than necessary.