[coreboot-gerrit] [M] Change in coreboot[main]: soc/intel/xeon_sp: Add device and domain find utils for stacks

[Shuo Liu (Code Review)]

Attention is currently required from: Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Tim Chu.

Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81043?usp=email )

Change subject: soc/intel/xeon_sp: Add device and domain find utils for stacks
......................................................................

Patch Set 6:

(2 comments)

File src/soc/intel/xeon_sp/chip_common.c:

https://review.coreboot.org/c/coreboot/+/81043/comment/cc946997_97382ccc :
PS6, Line 65: if (socket != XEONSP_SOCKET_MAX && dn.socket != socket)
            : 		return 0;
            : 	if (stack != XEONSP_STACK_MAX && dn.stack != stack)
            : 		return 0;
            : 	if (vendor != XEONSP_VENDOR_MAX && dev->vendor != vendor)
            : 		return 0;
            : 	if (device != XEONSP_DEVICE_MAX && dev->device != device)
            : 		return 0;
> Also check that the device is path is DEVICE_PATH_PCI ?

Acknowledged

File src/soc/intel/xeon_sp/include/soc/chip_common.h:

https://review.coreboot.org/c/coreboot/+/81043/comment/517bd3a9_6c2b7ce1 :
PS6, Line 19: (uint8_t)(-1)
> nit: UINT8_MAX from stdint. […]

Acknowledged