Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39613 )
Change subject: sc7180: Add display 10nm phy & pll programming support
......................................................................
Patch Set 27:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39613/23/src/soc/qualcomm/sc7180/in...
File src/soc/qualcomm/sc7180/include/soc/display/dsi_phy_pll.h:
https://review.coreboot.org/c/coreboot/+/39613/23/src/soc/qualcomm/sc7180/in...
PS23, Line 32: s64
I dont think here we need stdint header here.
The 's64' data type is defined in <stdint.h>, so yes, you need to include that header in this file. (Or, better, just include <types.h>, which chain includes stdint and a bunch of other things that you need so often that it's annoying to always include them separately.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39613
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ff400922ae594f558cf73a5aaa433a3a93347c2
Gerrit-Change-Number: 39613
Gerrit-PatchSet: 27
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Wed, 15 Jul 2020 01:49:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment