Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34686 )
Change subject: baytrail/rangeley: Update paths for FSP_FILE and VGA_BIOS_BIN
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/34686/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34686/5//COMMIT_MSG@7
PS5, Line 7: Update paths for FSP_FILE and VGA_BIOS_BIN
I don't see VGA_BIOS_BIN being changed, but rather VGA_BIOS_FILE. Typo?
https://review.coreboot.org/c/coreboot/+/34686/5/src/mainboard/adi/rcc-dff/K...
File src/mainboard/adi/rcc-dff/Kconfig:
https://review.coreboot.org/c/coreboot/+/34686/5/src/mainboard/adi/rcc-dff/K...
PS5, Line 39: config FSP_FILE
I would say the mainboard-specific Kconfig is now redundant, since it defines the same filepath as the SoC Kconfig
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34686
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35b0b08a13ad2deeb3e2efa146ab1916d5d23a14
Gerrit-Change-Number: 34686
Gerrit-PatchSet: 5
Gerrit-Owner: Name of user not set #1002476
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Aug 2019 21:49:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment