Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37231 )
Change subject: security/vboot: Remove struct vboot_working_data ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/37231/1/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/37231/1/src/security/vboot/common.c... PS1, Line 71: /* : * vboot prefers 16-byte alignment. This takes away 16 bytes : * from the VBOOT2_WORK region, but the vboot devs said that's okay. : */ : memset(wd, 0, sizeof(*wd)); : wd->buffer_offset = ALIGN_UP(sizeof(*wd), 16); Just a note here for posterity's sake -- we are standardizing on 8-byte alignment in this CL
https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_referen...
So it's definitely correct that we get rid of this comment and the 16-byte ALIGN_UP call.
https://review.coreboot.org/c/coreboot/+/37231/1/src/security/vboot/common.c... PS1, Line 39: (void *) Do we actually need a cast here?