Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29547 )
Change subject: security/vboot: Add measured boot mode
......................................................................
Patch Set 15:
(4 comments)
https://review.coreboot.org/#/c/29547/12/src/security/vboot/vboot_crtm.c
File src/security/vboot/vboot_crtm.c:
https://review.coreboot.org/#/c/29547/12/src/security/vboot/vboot_crtm.c@70
PS12, Line 70: romstage"
We do not need the leading slash here.
Done
https://review.coreboot.org/#/c/29547/12/src/security/vboot/vboot_crtm.c@77
PS12, Line 77: romstage"
We do not need the leading slash here.
Done
https://review.coreboot.org/#/c/29547/12/src/security/vboot/vboot_crtm.c@93
PS12, Line 93: verstage"
We do not need the leading slash here.
Done
https://review.coreboot.org/#/c/29547/12/src/security/vboot/vboot_crtm.c@100
PS12, Line 100: verstage"
We do not need the leading slash here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29547
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I339a2f1051e44f36aba9f99828f130592a09355e
Gerrit-Change-Number: 29547
Gerrit-PatchSet: 15
Gerrit-Owner: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Krystian Hebel
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 21 Nov 2018 18:19:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment