[coreboot-gerrit] Change in coreboot[master]: mb/google/zork/var/vilboz: Add enable use_external_48MHz_osc flag

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48556 )

Change subject: mb/google/zork/var/vilboz: Add enable use_external_48MHz_osc flag
......................................................................

Patch Set 12:

(5 comments)

https://review.coreboot.org/c/coreboot/+/48556/9/src/mainboard/google/zork/m... 
File src/mainboard/google/zork/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48556/9/src/mainboard/google/zork/m... 
PS9, Line 165: variant_mainboard_init
> variant_devtree_update() already exists to allow this. You don't need another callback. […]

Done

https://review.coreboot.org/c/coreboot/+/48556/10/src/mainboard/google/zork/... 
File src/mainboard/google/zork/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48556/10/src/mainboard/google/zork/... 
PS10, Line 163:
> remove the extra line

Done

https://review.coreboot.org/c/coreboot/+/48556/10/src/mainboard/google/zork/... 
File src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h:

https://review.coreboot.org/c/coreboot/+/48556/10/src/mainboard/google/zork/... 
PS10, Line 84:
> not necessary change.

Done

https://review.coreboot.org/c/coreboot/+/48556/9/src/mainboard/google/zork/v... 
File src/mainboard/google/zork/variants/vilboz/variant.c:

https://review.coreboot.org/c/coreboot/+/48556/9/src/mainboard/google/zork/v... 
PS9, Line 39:
> A comment here would be very helpful explaining why this config is set for LTE/WWAN variants.

Done

https://review.coreboot.org/c/coreboot/+/48556/9/src/mainboard/google/zork/v... 
PS9, Line 40: if (variant_has_wwan())
> Interesting question. […]

Done