Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jeremy Soller, Kapil Porwal, Tarun, Tim Crawford.
Subrata Banik has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82733?usp=email )
Change subject: soc/intel/mtl: Fill in SPD data on both channels of DDR5 memory
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82733/comment/e93de523_8ac73740?usp... :
PS1, Line 14:
looks like you are trying to change the existing system behavior where we prefer to read SPD via SMBUS. Rather you are trying to pass the SPD static data for DDR5 as well.
technically, what you are trying is yet another way to fill the SPD but that doesn't mean we shall drop the SMBUS read (which would allow anyone to alter the DIMM w/o really need to bother about passing SPD hex data for each DIMM configuration.
hence, my suggestion is to add some Kconfig kind if possible to keep SPD fill vis SMBUS in parallel to fill SPD using static hex data w/o dropping the previous one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82733?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I600d8fd480cb84d5dcb679e4f0bdeeaaebfab386
Gerrit-Change-Number: 82733
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Sat, 01 Jun 2024 07:19:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No