build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50710 )
Change subject: mb/asrock/e350m1: Configure HWM ......................................................................
Patch Set 1:
(59 comments)
File src/mainboard/asrock/e350m1/bootblock.c:
https://review.coreboot.org/c/coreboot/+/50710/comment/82a39ab1_64a11d40 PS1, Line 19: nct5572d_hwm_init(HWM_DEV, HWM_BASE); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/3517e966_b7c5c953 PS1, Line 19: nct5572d_hwm_init(HWM_DEV, HWM_BASE); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/ca058f46_57036606 PS1, Line 21: /* The NCT3941S on CHA_FAN1 takes a PWM signal, not a voltage signal */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/ff72aeb2_720e6dc4 PS1, Line 22: nct5572d_hwm_set_sysfan_out_voltage_mode(HWM_BASE, false); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/bc493e5e_d406a5c8 PS1, Line 22: nct5572d_hwm_set_sysfan_out_voltage_mode(HWM_BASE, false); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/601634da_a68af7bf PS1, Line 24: /* Force all fan outputs to full speed */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/041016f9_abd431af PS1, Line 25: nct5572d_hwm_force_fan_full_on(HWM_BASE, CPU_FAN); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/5056d9ef_7151d8a0 PS1, Line 25: nct5572d_hwm_force_fan_full_on(HWM_BASE, CPU_FAN); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/ad5bc9a6_4efb7a19 PS1, Line 26: nct5572d_hwm_force_fan_full_on(HWM_BASE, CHA_FAN1); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/1c08009e_615fe493 PS1, Line 26: nct5572d_hwm_force_fan_full_on(HWM_BASE, CHA_FAN1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/059dd05d_e919f0e0 PS1, Line 27: nct5572d_hwm_force_fan_full_on(HWM_BASE, CHA_FAN2); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/1022c14c_3a05e677 PS1, Line 27: nct5572d_hwm_force_fan_full_on(HWM_BASE, CHA_FAN2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/88c74a1b_08b08293 PS1, Line 29: nct5572d_hwm_enable_peci(HWM_BASE, 0x5c); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/b8e8d2cd_12763a02 PS1, Line 29: nct5572d_hwm_enable_peci(HWM_BASE, 0x5c); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/a51f476d_bb3e074a PS1, Line 32: struct nct5572d_hwm_speed_cruise_params scp = { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/ba880d1c_b822581d PS1, Line 32: struct nct5572d_hwm_speed_cruise_params scp = { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/e2d855ab_b1496964 PS1, Line 33: .target_speed = 4095, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/927fb9ab_24378e46 PS1, Line 33: .target_speed = 4095, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/f35b0ecd_1ad63f3c PS1, Line 34: .tolerance = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/2d505673_c99252be PS1, Line 34: .tolerance = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/6d9fbacd_10cf1e66 PS1, Line 35: .step_up_time = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/97bb7323_a14d5a95 PS1, Line 35: .step_up_time = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/013720a7_ba872fc2 PS1, Line 36: .step_down_time = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/b0623cb2_311f1662 PS1, Line 36: .step_down_time = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/c08dcee2_edf21537 PS1, Line 37: }; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/181cbd42_8257e2c5 PS1, Line 37: }; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/b0a1721b_31c1ec6f PS1, Line 39: nct5572d_hwm_program_speed_cruise(HWM_BASE, CPU_FAN, &scp); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/a9f216ca_6ff82ea0 PS1, Line 39: nct5572d_hwm_program_speed_cruise(HWM_BASE, CPU_FAN, &scp); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/29ab0574_63f9bc45 PS1, Line 41: /* Example of temperature-controlled fans with thermal cruise mode */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/e267c2fd_db3d8107 PS1, Line 42: struct nct5572d_hwm_thermal_cruise_params tcp = { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/14f3c19c_fba9552a PS1, Line 42: struct nct5572d_hwm_thermal_cruise_params tcp = { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/af829f2a_0f3b5aaf PS1, Line 43: .target_temp = 55, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/a3bfb942_81925577 PS1, Line 43: .target_temp = 55, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/e94500bf_9111c721 PS1, Line 44: .tolerance = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/8f2cea3a_9310d3dd PS1, Line 44: .tolerance = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/65960cb2_009f6471 PS1, Line 45: .start_up_val = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/2263d1aa_96b6a950 PS1, Line 45: .start_up_val = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/a68fd6f8_ee08eb10 PS1, Line 46: .stop_val = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/8d0c21fb_d0f10006 PS1, Line 46: .stop_val = 0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/fb036564_1514ca5b PS1, Line 47: .stopduty_en = false, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/8356a286_c6ed9fe9 PS1, Line 47: .stopduty_en = false, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/a56b822a_a7fd4567 PS1, Line 48: .stop_time = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/4215a09e_f6637cd7 PS1, Line 48: .stop_time = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/5c05231d_6d91b0c1 PS1, Line 49: .step_up_time = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/ec7685bd_4d1338b0 PS1, Line 49: .step_up_time = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/fd59bbcc_5ea11788 PS1, Line 50: .step_down_time = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/b74f93c7_09532c2f PS1, Line 50: .step_down_time = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/cc47fcc7_d26149dc PS1, Line 51: .critical_temp = 60, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/72a2930b_6bb9866a PS1, Line 51: .critical_temp = 60, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/18032d07_bc2dba13 PS1, Line 52: .temp_src = PECI_0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/7cc72e20_008eb5dc PS1, Line 52: .temp_src = PECI_0, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/2566a109_9819d636 PS1, Line 53: }; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/c483ae37_26bffda5 PS1, Line 53: }; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/b05faf4d_4ba01ea8 PS1, Line 55: nct5572d_hwm_program_thermal_cruise(HWM_BASE, CPU_FAN, &tcp); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/3e0cc593_5d2bc5ad PS1, Line 55: nct5572d_hwm_program_thermal_cruise(HWM_BASE, CPU_FAN, &tcp); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/53b55899_c647cd06 PS1, Line 56: nct5572d_hwm_program_thermal_cruise(HWM_BASE, CHA_FAN1, &tcp); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/83689d87_fe95f91e PS1, Line 56: nct5572d_hwm_program_thermal_cruise(HWM_BASE, CHA_FAN1, &tcp); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/50710/comment/4b28cfb0_37c2196f PS1, Line 57: nct5572d_hwm_program_thermal_cruise(HWM_BASE, CHA_FAN2, &tcp); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/50710/comment/56a88307_3b58f35d PS1, Line 57: nct5572d_hwm_program_thermal_cruise(HWM_BASE, CHA_FAN2, &tcp); please, no spaces at the start of a line