build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30466 )
Change subject: fu540: add code to initialize flash ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/#/c/30466/8/src/soc/sifive/fu540/include/soc/spi... File src/soc/sifive/fu540/include/soc/spi.h:
https://review.coreboot.org/#/c/30466/8/src/soc/sifive/fu540/include/soc/spi... PS8, Line 20: #define _ASSERT_SIZEOF(type, size) _Static_assert(sizeof(type) == (size), #type " must be " #size " bytes wide") line over 80 characters
https://review.coreboot.org/#/c/30466/8/src/soc/sifive/fu540/include/soc/spi... PS8, Line 233: // This should not overflow as long as (f_in - 1 + 2*f_sck) does not exceed line over 80 characters
https://review.coreboot.org/#/c/30466/8/src/soc/sifive/fu540/spi.c File src/soc/sifive/fu540/spi.c:
https://review.coreboot.org/#/c/30466/8/src/soc/sifive/fu540/spi.c@33 PS8, Line 33: while ((int32_t) spictrl->txdata.raw_bits < 0); trailing statements should be on next line
https://review.coreboot.org/#/c/30466/8/src/soc/sifive/fu540/spi.c@45 PS8, Line 45: while ((out = (int32_t) spictrl->rxdata.raw_bits) < 0); trailing statements should be on next line