Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39769 )
Change subject: nb/intel/haswell: Implement proper backlight PWM config ......................................................................
Patch Set 6: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/39769/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39769/6//COMMIT_MSG@14 PS6, Line 14: e assume that the 183Hz value that was set before for Slippy : variants was overridden by Linux with the 200Hz VBT value, like : it was for the Broadwell Chromebooks. So we set 200Hz for them : in the devicetrees. The calculated value for the T440p of 220Hz : seems sane and also matches the VBT. I can't find the history in our internal bug database so I'm going to assume this is correct.
https://review.coreboot.org/c/coreboot/+/39769/6/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/39769/6/src/northbridge/intel/haswe... PS6, Line 365: 1 << 5 maybe add a #define for this?