Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34939 )
Change subject: Add definition for ENV_ROMSTAGE_OR_BEFORE to <rules.h>
......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34939/5/src/cpu/Kconfig
File src/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/34939/5/src/cpu/Kconfig@19
PS5, Line 19: default n
This was anticipation for CB:32414 without pulling that commit into my branch.
Ack
https://review.coreboot.org/c/coreboot/+/34939/6/src/include/rules.h
File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/34939/6/src/include/rules.h@289
PS6, Line 289: #if !ENV_RAMSTAGE
So I removed the !ENV_PAYLOAD_LOADER here. […]
Ack
https://review.coreboot.org/c/coreboot/+/34939/6/src/include/symbols.h
File src/include/symbols.h:
https://review.coreboot.org/c/coreboot/+/34939/6/src/include/symbols.h@73
PS6, Line 73: static inline int preram_symbols_available(void)
Do we want ARCH_STAGE_HAS_PRERAM_SYMBOLS instead?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd2292f922ccb9e79d10ca9bc35797048d174287
Gerrit-Change-Number: 34939
Gerrit-PatchSet: 12
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 22 Aug 2019 02:56:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment